-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entities loading #836
Merged
Merged
Entities loading #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't pass props for the EntitiesPage through withEntitiesContainer HOC.
Don't pass the props through withEntititesContainer HOC.
When calling gmp.notes.get and gmp.notes.getAll always load the whole details of the note entities.
The "path" to the nvt entities must be rootState.entities.nvt
We are using operatingsystem as command name. Therefore the entities functions must use it too.
filterFilter prop isn't used in EntitiesContainer therefore it should be passed directly to EntitiesPage.
flex is by default true and box isn't used anymore.
Make the operatingsystem path more consistent and use the gsa name for os.
Don't pass EntitiesPage props through the withEntitesContainer HOC.
* Always set default value for inheritor selection. * Use camelCase for inheritorId. * Adjust imports * Rename users prop to inheritorUsers * Only use deleteUsers array instead of special props for single user deletion * Use renderSelectItems to render list of inheritor users.
Also update users list page to ConfirmDeleteDialog changes.
Wrapper was a placeholder before React Fragment has been introduced.
Don't access the context directly.
Move withEntitiesContainer2.js into withEntitiesContainer.js and update all imports to use the new path.
Move new version into the path of the old one.
bjoernricks
removed
the
work in progress
This pull request should not be merged yet, more commits are expected
label
Jul 27, 2018
swaterkamp
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 4