Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities loading #836

Merged
merged 71 commits into from
Jul 27, 2018
Merged

Entities loading #836

merged 71 commits into from
Jul 27, 2018

Conversation

bjoernricks
Copy link
Contributor

Part 4

Don't pass props for the EntitiesPage through withEntitiesContainer HOC.
Don't pass the props through withEntititesContainer HOC.
When calling gmp.notes.get and gmp.notes.getAll always load the whole
details of the note entities.
The "path" to the nvt entities must be rootState.entities.nvt
We are using operatingsystem as command name. Therefore the entities
functions must use it too.
filterFilter prop isn't used in EntitiesContainer therefore it should be
passed directly to EntitiesPage.
flex is by default true and box isn't used anymore.
Make the operatingsystem path more consistent and use the gsa name for
os.
Don't pass EntitiesPage props through the withEntitesContainer HOC.
* Always set default value for inheritor selection.
* Use camelCase for inheritorId.
* Adjust imports
* Rename users prop to inheritorUsers
* Only use deleteUsers array instead of special props for single user
  deletion
* Use renderSelectItems to render list of inheritor users.
Also update users list page to ConfirmDeleteDialog changes.
Wrapper was a placeholder before React Fragment has been introduced.
Don't access the context directly.
Move withEntitiesContainer2.js into withEntitiesContainer.js and update
all imports to use the new path.
Move new version into the path of the old one.
@bjoernricks bjoernricks removed the work in progress This pull request should not be merged yet, more commits are expected label Jul 27, 2018
@swaterkamp swaterkamp merged commit d69b46b into greenbone:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants