-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert glamorous to styled-components #3 #919
Merged
bjoernricks
merged 17 commits into
greenbone:master
from
swaterkamp:glamorous2styledcomponents
Sep 6, 2018
Merged
Convert glamorous to styled-components #3 #919
bjoernricks
merged 17 commits into
greenbone:master
from
swaterkamp:glamorous2styledcomponents
Sep 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't export TableBody as a named export. It's never used anywhere.
Change appearance (green bottom line) and remove padding-bottom as it doesn't seem to make a difference.
Change margin-bottom to fit design change in tablayout
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
=========================================
- Coverage 7.39% 7.39% -0.01%
=========================================
Files 826 826
Lines 26844 26856 +12
Branches 5721 5702 -19
=========================================
Hits 1986 1986
- Misses 22437 22440 +3
- Partials 2421 2430 +9
Continue to review full report at Codecov.
|
swaterkamp
force-pushed
the
glamorous2styledcomponents
branch
from
September 6, 2018 12:37
6ddc419
to
d2b5ff4
Compare
bjoernricks
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #643