Report load from store #923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
=========================================
+ Coverage 7.37% 7.49% +0.12%
=========================================
Files 826 826
Lines 26873 26908 +35
Branches 5731 5740 +9
=========================================
+ Hits 1982 2018 +36
+ Misses 22449 22443 -6
- Partials 2442 2447 +5
Continue to review full report at Codecov.
|
| @@ -499,7 +499,7 @@ const PageContent = ({ | |||
| onFilterDecreaseMinQoDClick={onFilterDecreaseMinQoDClick} | |||
| onFilterRemoveSeverityClick={onFilterRemoveSeverityClick} | |||
| onFilterEditClick={onFilterEditClick} | |||
| onFilterResetClick={onFilterResetClick} | |||
| onFilterRemoveClick={onFilterRemoveClick} | |||
| onInteraction={onInteraction} | |||
There was a problem hiding this comment.
Why not keep both options? Removing the reset-option makes it impossible to easily apply the default filter
There was a problem hiding this comment.
I've only fixed the current behavior of the displayed box. If you think we should add another box when no results are available to actually reset the filter to the detauls a new PR is always welcome 😄
| @@ -153,6 +159,20 @@ class ReportDetails extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| startMeasurement() { | |||
There was a problem hiding this comment.
Maybe these methods could get a more meaningful name. It's not clear from the title alone that time for auto-updates is measured. Could also be "number of scrolled pixels" or basically anything else...
There was a problem hiding this comment.
Actually it could measure all kind of durations but currently it's only used for the load duration. So I suppose you are right with changing the name would be better.
There was a problem hiding this comment.
As it can measure any kind of duration something like startDurationMeasurement() would be quite informative. We don't need to restrict this method to startLoadDurationMeasurement() or anything like that.
The test description wasn't changed after the method got renamed.
Allow to pass a filter for the results when loading a report. Update report loadEntity tests accordingly.
Allow to handle delta reports in the redux store.
Refactor the report details page to load all data from the redux store.
Use new camelCase data from the report details page at report details page content.
Resetting meand using the default results filter which may still not show all results. Therefore allow the user to remove the current applied filter completely.
It's not possible to get the target from the store directly after loading it into the store when opening the edit dialog. The correct target isn't passed to the details page before the dialog is open. Therefore bypass the store and load the target directly.
If the filter isn't reset the report list would keep the task_id filter when visiting the report list again.
Automatically reload the report if it is active.
Rename start/endMeasurement to start/endDurationMeasurement
Load the report data from store and adjust auto reload for report details.