Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let it work with cmake and cmake3. #936

Merged
merged 2 commits into from
Sep 12, 2018

Conversation

tuxmaster5000
Copy link
Contributor

Use the variable for cmake instant of hard coded cmake call.

@bjoernricks
Copy link
Contributor

Thanks!

@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #936 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #936      +/-   ##
=========================================
+ Coverage    7.51%   7.51%   +<.01%     
=========================================
  Files         826     826              
  Lines       26895   26895              
  Branches     5723    5694      -29     
=========================================
+ Hits         2020    2021       +1     
+ Misses      22439   22438       -1     
  Partials     2436    2436
Impacted Files Coverage Δ
gsa/src/gmp/gmpsettings.js 100% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6e75d...bb35637. Read the comment docs.

@bjoernricks bjoernricks merged commit 7198768 into greenbone:master Sep 12, 2018
@tuxmaster5000 tuxmaster5000 deleted the cmake3 branch September 12, 2018 11:22
@bjoernricks
Copy link
Contributor

@tuxmaster5000 would like like to be named at the https://github.com/greenbone/gsa/blob/master/CHANGES.md file?

@tuxmaster5000
Copy link
Contributor Author

Hi Björn, yes you can do it.

@bjoernricks
Copy link
Contributor

@tuxmaster5000 as tuxmaster5000 or another name? We are using real names for the changes normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants