Unify dashboards #974
Merged
Unify dashboards #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dashboard at the main dashboard is removed also remove the default settings for this dashboard.
Allow to pass a id generator function to createRow, createItem and convertDefaultContent functions.
When creating a new dashboard at the main page allow to pass an array of default displays.
Remove the hack to put the defaults of the dashboards into the store when the dashboard is rendered for the first time.
When a new dashboard will be added to the main page allow to select a "template" of displays to show initially.
These dashboards can now be created at the main page.
These pages are obsolete now.
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
=========================================
+ Coverage 9.12% 9.13% +<.01%
=========================================
Files 819 814 -5
Lines 26748 26625 -123
Branches 5713 5713
=========================================
- Hits 2441 2432 -9
+ Misses 21966 21856 -110
+ Partials 2341 2337 -4
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.