Donut chart size calculation improvements #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default this ratio is 0 now so we get a pie chart instead of a donut chart.
In this case all four margins have been set to 20 pixels thus there is no difference in the outcome but this may change in future.
Don't allow to stretch a donut vertically and always use same size for height and width for 2d donut charts.
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
=========================================
- Coverage 9.11% 9.11% -0.01%
=========================================
Files 818 818
Lines 26678 26682 +4
Branches 5702 5731 +29
=========================================
Hits 2432 2432
- Misses 21899 21900 +1
- Partials 2347 2350 +3
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.