Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI miscellaneous #991

Merged
merged 10 commits into from
Oct 4, 2018
Merged

GUI miscellaneous #991

merged 10 commits into from
Oct 4, 2018

Conversation

swaterkamp
Copy link
Member

  • Put NVT preferences inside own tab on detailspage
  • Fix filtering download options of ReportFormats
  • Change Table for Report summary
  • ...some clean-up

@swaterkamp swaterkamp self-assigned this Oct 4, 2018
@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #991 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #991      +/-   ##
=========================================
+ Coverage    9.11%   9.11%   +<.01%     
=========================================
  Files         821     821              
  Lines       26744   26741       -3     
  Branches     5717    5745      +28     
=========================================
  Hits         2437    2437              
+ Misses      21947   21942       -5     
- Partials     2360    2362       +2
Impacted Files Coverage Δ
...a/src/web/pages/reports/reportentitiescontainer.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/nvts/table.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/nvts/references.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/nvts/preferences.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/nvts/detailspage.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/reports/scaninfo.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/nvts/nvtpreference.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/nvts/details.js 0% <0%> (ø) ⬆️
gsa/src/web/entity/page.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/reports/summary.js 0% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea8db8...e4148ea. Read the comment docs.

@swaterkamp swaterkamp requested a review from a team October 4, 2018 07:51
@bjoernricks bjoernricks merged commit b31b6aa into greenbone:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants