Create React App 2.0 #997
Merged
Create React App 2.0 #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 first yarn build did take 270s. Additional runs only take 60 secs now. |
This brings wepback 4, babel 7 and jest 23 finally.
Storybook 3 isn't compatible with cra 2.0 and Storybook 4 isn't stable yet.
We don't use them at the moment. So the code can be removed.
This settings is used to determine the applied transforms of babel 7.
Passing env=jsdom to react-scripts test is the default now and not necessary anymore.
It seems jest 23 (or cra 2.0) doesn't provide an implementation for requestAnimationFrame anymore.
swaterkamp
previously approved these changes
Oct 5, 2018
Set react version to get rid of "Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration."
Remove eslint warnings and errors caused by updating to cra 2.0
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
=========================================
+ Coverage 9.3% 9.35% +0.05%
=========================================
Files 822 822
Lines 26747 26595 -152
Branches 5722 5601 -121
=========================================
Hits 2488 2488
- Misses 21904 22488 +584
+ Partials 2355 1619 -736
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reactjs.org/blog/2018/10/01/create-react-app-v2.html