Change: support error recovery during nasl parsing #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
previously approved these changes
Feb 24, 2022
Now is possible to detect more than one syntax error during the parsing.
Without the patch, only the first error was shown and the file must be parsed once for each error.$ cat linter-test.nasl
For testing, run the following nasl script with `openvas-nasl-lint linter-test.nasl`
```
display ("AAAAAA")
a = "1234";
display("bbbbbb")
d = 1234;
display("CCCCCC");
display("DDDDDD);
```
jjnicola
force-pushed
the
parse-err-recover
branch
from
af928e1
to
3021fcb
Compare
ArnoStiefvater
approved these changes
Mar 1, 2022
nichtsfrei
approved these changes
Mar 1, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
Now is possible to detect more than one syntax error during the parsing.
Without the patch, only the first error was shown and the file must be parsed once for each error.$ cat linter-test.nasl
For testing, run the following nasl script with `openvas-nasl-lint linter-test.nasl`
```
display ("AAAAAA")
a = "1234";
display("bbbbbb")
d = 1234;
display("CCCCCC");
display("DDDDDD);
```
(cherry picked from commit b55ffd5)
# Conflicts:
# nasl/nasl_grammar.y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Change: support error recovery during nasl parsing
Jira: SC-169
Why:
Now is possible to detect more than one syntax error during the parsing.
Without the patch, only the first error was shown and the file must be parsed once for each error.$ cat linter-test.nasl
How:
For testing, run the following nasl script with
openvas-nasl-lint linter-test.naslChecklist: