Remove: remove MD5 support from feed integrity check #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since long, SHA256 is the default algorithm to check the nasl scripts checksum.
nichtsfrei
force-pushed
the
remove-md5-integrity-check
branch
from
a45547d
to
ae545aa
Compare
nichtsfrei
approved these changes
Mar 17, 2022
Kraemii
approved these changes
Mar 17, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
Since long, SHA256 is the default algorithm to check the nasl scripts checksum. (cherry picked from commit 893c2b2)
ArnoStiefvater
pushed a commit
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Since long, SHA256 is the default algorithm to check the nasl scripts checksum.
Jira SC-558
Why:
It was deprecated and not used anymore
How:
Run the plugin upload with signature check enabled, and in redis you must see the sha256 hashes loaded, as before. Unless you have a special setup without sha256sum support, there should not be changes in respect with the current behaviour.
Checklist: