Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Use return instead of exit in openvas.c #1155

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Aug 16, 2022

What:

Jira: SC-564

Change: Use return instead of exit …
Use return instead of exit in openvas.c:openvas() function.
Also, use macros EXIT_FAILURE and EXIT_SUCCESS instead of 0, 1 or -1, as expected by the main() function in main.c

Change: make attack_network_init() a int function. …
Used return instead of exit inside function.
Use the return value in caller function.

Change: make stop_single_task_scan() a int function. …
Used return instead of exit in function.
Use the return value in caller function.

Why:

How:

Checklist:

  • Tests
  • PR merge commit message adjusted

Use return instead of exit in  openvas.c:openvas() function.
Also, use macros EXIT_FAILURE and EXIT_SUCCESS instead of 0, 1 or -1, as expected by the main() function in main.c
@jjnicola jjnicola requested a review from a team as a code owner August 16, 2022 09:10
@jjnicola jjnicola enabled auto-merge (squash) August 16, 2022 09:10
Used return instead of exit inside function.
Use the return value in caller function.
Used return instead of exit in function.
Use the return value in caller function.
@jjnicola jjnicola force-pushed the exit-return branch 2 times, most recently from 940d58d to 9b48397 Compare August 16, 2022 11:36
@jjnicola jjnicola merged commit 3ac3f51 into greenbone:main Aug 16, 2022
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
* Change: Use return instead of exit

Use return instead of exit in  openvas.c:openvas() function.
Also, use macros EXIT_FAILURE and EXIT_SUCCESS instead of 0, 1 or -1, as expected by the main() function in main.c

* Change: make attack_network_init() a int function.
Used return instead of exit inside function.
Use the return value in caller function.

* Change: make stop_single_task_scan() a int function.
Used return instead of exit in function.
Use the return value in caller function.

(cherry picked from commit 3ac3f51)
nichtsfrei pushed a commit that referenced this pull request Aug 23, 2022
* Change: Use return instead of exit

Use return instead of exit in  openvas.c:openvas() function.
Also, use macros EXIT_FAILURE and EXIT_SUCCESS instead of 0, 1 or -1, as expected by the main() function in main.c

* Change: make attack_network_init() a int function.
Used return instead of exit inside function.
Use the return value in caller function.

* Change: make stop_single_task_scan() a int function.
Used return instead of exit in function.
Use the return value in caller function.

(cherry picked from commit 3ac3f51)
@nichtsfrei nichtsfrei mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants