Remove: unnecessary code in libs CMakeLists.txt files #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Kraemii
reviewed
Aug 17, 2022
ArnoStiefvater
approved these changes
Aug 18, 2022
Remove the project string setup code for the nasl and misc CMakeLists.txt files, since the main project version string is already used.
Co-authored-by: Christoph Krämer <c.kraemer.rulle@web.de>
ArnoStiefvater
force-pushed
the
libs-versions
branch
from
c1e50f4
to
a1c01b5
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Remove: unnecessary code in libs CMakeLists.txt files Remove the project string setup code for the nasl and misc CMakeLists.txt files, since the main project version string is already used. (cherry picked from commit b614dbd)
ArnoStiefvater
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Remove: unnecessary code in libs CMakeLists.txt files Remove the project string setup code for the nasl and misc CMakeLists.txt files, since the main project version string is already used. (cherry picked from commit b614dbd)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove the project string setup code for the nasl and misc CMakeLists.txt files
Jira: SC-654
Why:
The main project version string is already used.
How:
Run cmake and compile (with and without release flag, with and without dev version var set). Check the installed binary's names
Checklist: