Add: fork observing mechanism #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kraemii
force-pushed
the
fork-observing-mechanism
branch
2 times, most recently
from
d9c4d9d
to
0b93e26
Compare
nichtsfrei
requested changes
Aug 19, 2022
Kraemii
force-pushed
the
fork-observing-mechanism
branch
2 times, most recently
from
8da0c6b
to
ef186d5
Compare
This PR extends the process module and allows to manage forked childs as well sets a limit to the number of forks possible. It also cleans up child processes.
Kraemii
force-pushed
the
fork-observing-mechanism
branch
from
ef186d5
to
da013e9
Compare
nichtsfrei
approved these changes
Aug 19, 2022
jjnicola
reviewed
Aug 22, 2022
| { | ||
| int pid; | ||
|
|
||
| gvm_log_lock (); |
There was a problem hiding this comment.
Why did you remove this? This code was introduced some time ago to avoid deadlock. See PR #491
Kraemii
added a commit
that referenced
this pull request
Aug 22, 2022
The PR #1165 contained two major errors. A lock to prevent a deadlock and handling signals in case the module is not initialized
2 tasks
Kraemii
added a commit
that referenced
this pull request
Aug 22, 2022
The PR #1165 contained two major errors. A lock to prevent a deadlock and handling signals in case the module is not initialized
Kraemii
added a commit
that referenced
this pull request
Aug 22, 2022
The PR #1165 contained two major errors. A lock to prevent a deadlock and handling signals in case the module is not initialized
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
This PR extends the process module and allows to manage forked childs as well sets a limit to the number of forks possible. It also cleans up child processes. (cherry picked from commit c72b6df)
nichtsfrei
pushed a commit
that referenced
this pull request
Sep 7, 2022
This PR extends the process module and allows to manage forked childs as well sets a limit to the number of forks possible. It also cleans up child processes. (cherry picked from commit c72b6df)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR extends the process module and allows to manage forked childs as well sets a limit to the number of forks possible. It also cleans up child processes.
Jira: SC-565
Why:
In order to use IPC some sort of fork observing mechanism is necessary
How:
Checklist: