Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set transport again if falls back in a unecrypted connection #1190

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Sep 8, 2022

What:
In case of falling back in a unencrypted connection, set the transport to OPENVAS_ENCAPS_IP (1) again.
Jira: SC-664

Why:
The transport was kept as OPENVAS_ENCAPS_TLScustom (9)

How:
Run an authenticated scan against a windows. The scan config can be a base ScanConfig + smb_login.nasl.
Without the patch the login is not successful, with patch is possible to login agian.

Checklist:

  • Tests
  • PR merge commit message adjusted

In case of falling back in a unencrypted connection, set the transport to OPENVAS_ENCAPS_IP again.
@jjnicola jjnicola marked this pull request as ready for review September 8, 2022 10:59
@jjnicola jjnicola requested a review from a team as a code owner September 8, 2022 10:59
@jjnicola jjnicola enabled auto-merge (squash) September 8, 2022 11:00
@jjnicola jjnicola merged commit c4f5a8c into greenbone:main Sep 8, 2022
mergify bot pushed a commit that referenced this pull request Sep 8, 2022
)

In case of falling back in a unencrypted connection, set the transport to OPENVAS_ENCAPS_IP again.

(cherry picked from commit c4f5a8c)
jjnicola added a commit that referenced this pull request Sep 8, 2022
) (#1191)

In case of falling back in a unencrypted connection, set the transport to OPENVAS_ENCAPS_IP again.

(cherry picked from commit c4f5a8c)

Co-authored-by: Juan José Nicola <juan.nicola@greenbone.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants