Fix: initialize global_max_hosts and global_max_checks from config file #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnoStiefvater
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix: initialize global_max_hosts and global_max_checks from config file
Jira: SC-696
Why:
the settings were not initialized and the defaults (hardcoded) where set instead. Therefore if the client sent a max_checks and max_hosts grather than defaults, the setting was not applied, since the settings from the configuration file were not taken.
How:
Hardcoded defaults are
max_hosts = 15andmax_checks = 10.max_hosts = 30andmax_checks = 15.max_hosts = 25andmax_checks = 13. (greather than defaults and lower than in the config file)Repeat the test with and without the patch.
Checklist: