Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Improve stop_denial. Test the host if still alive with boreas #1345

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Change: Improve stop_denial. Test the host if still alive with boreas #1345

merged 3 commits into from
Mar 1, 2023

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Feb 22, 2023 •
edited
Loading

What:
Improve stop_denial. Test the host if still alive with boreas
Jira: SC-772

Why:
Some plugins produce the host scan to finish earlier because false positive.

How:

Checklist:

  • Tests
  • PR merge commit message adjusted

@jjnicola jjnicola requested a review from a team as a code owner February 22, 2023 07:33
@jjnicola jjnicola enabled auto-merge (squash) February 22, 2023 07:33
nichtsfrei
nichtsfrei reviewed Feb 22, 2023
View reviewed changes
nasl/nasl_misc_funcs.c Outdated Show resolved Hide resolved
@jjnicola jjnicola force-pushed the heartbeat branch 2 times, most recently from 8823707 to 15411e9 Compare February 22, 2023 14:03
nichtsfrei
nichtsfrei previously approved these changes Feb 23, 2023
View reviewed changes
ArnoStiefvater
ArnoStiefvater requested changes Feb 28, 2023
View reviewed changes
misc/heartbeat.c Outdated Show resolved Hide resolved
@jjnicola jjnicola merged commit d73cae3 into main Mar 1, 2023
@jjnicola jjnicola deleted the heartbeat branch March 1, 2023 08:58
@mergify mergify bot mentioned this pull request Mar 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 17, 2023
@jjnicola @mergify
Change: Improve stop_denial. Test the host if still alive with boreas (…
2abf328 
…#1345)

* Change: move heartbeat function to its own file

* Change: Improve stop_denial. Test the host if still alive with boreas

(cherry picked from commit d73cae3)
jjnicola added a commit that referenced this pull request Mar 17, 2023
@jjnicola
Change: Improve stop_denial. Test the host if still alive with boreas (…
d50e672 
…#1345)

* Change: move heartbeat function to its own file

* Change: Improve stop_denial. Test the host if still alive with boreas

(cherry picked from commit d73cae3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kraemii Kraemii Kraemii approved these changes

@ArnoStiefvater ArnoStiefvater ArnoStiefvater approved these changes

@nichtsfrei nichtsfrei Awaiting requested review from nichtsfrei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjnicola @nichtsfrei @ArnoStiefvater @Kraemii