Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: support nasl SSH functions #1368

Merged
merged 30 commits into from
Apr 27, 2023
Merged

Add: support nasl SSH functions #1368

merged 30 commits into from
Apr 27, 2023

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Mar 23, 2023 •
edited
Loading

What:
Add: support nasl SSH functions
Jira: SC-790

Why:

How:
Run the script:
OPENVAS_LIBSSH_DEBUG=10 nasl-cli --verbose execute ../examples/ssh_test.nasl 

session_id = ssh_connect(port: 22, keytype: "ssh-rsa,ssh-dss");
display(session_id);

auth = ssh_userauth(session_id, login: "user", password: "pass");
display(auth);

res = ssh_request_exec(session_id, cmd:"ls", stdout: 1, stderr: 1);
display(res);

disconn = ssh_disconnect(session_id);
display(disconn);

Checklist:

  • Tests
  • PR merge commit message adjusted

@jjnicola jjnicola force-pushed the rs-ssh branch 2 times, most recently from 3b1c409 to a7b7e3f Compare March 23, 2023 08:01
@jjnicola jjnicola force-pushed the rs-ssh branch 2 times, most recently from e3f3322 to 6025a2b Compare March 31, 2023 13:27
@jjnicola jjnicola force-pushed the rs-ssh branch 3 times, most recently from 18d7050 to 9524a0a Compare April 17, 2023 06:24
@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

Conventional Commits Report

Type Number
Added 19
Changed 3
Bug Fixes 5

🚀 Conventional commits found.

@jjnicola jjnicola force-pushed the rs-ssh branch 2 times, most recently from b589458 to 9eedbff Compare April 21, 2023 10:41
@jjnicola jjnicola changed the title Add: Basic structure of nasl SSH functions Add: support nasl SSH functions Apr 21, 2023
jjnicola and others added 17 commits April 24, 2023 10:58
@jjnicola
Add: Basic structure of nasl SSH functions
edce3bb 
Also, implement a draft for nasl_ssh_connect and session handler structures
@jjnicola
Use Diagnostic instead of the logger
d4dc41e
@jjnicola
Add:session handlers
7b9c8c5
@jjnicola
Change session handler.
ea165ac 
Implement disconnect() in nasl_ssh.rs, login() and partially userauth()
Solve conflicts with the return error in nasl functions (Return an FunctionErrorKind)
Adjust format
@jjnicola
Fix: session share and create a structure for holding connection options
c4a91ca
@jjnicola
Code rework and implement another authentication methods.
a97e449
@jjnicola
Fix: test in README
61d6852
@jjnicola
Add: authentication method via public key
008ba51 
Also, uses a personal cargo version, until contributions are merged in the libssh-rs cargo project and released
@jjnicola
Add: login interactive
f0c9790
@jjnicola
Add: ssh_request_exec()
464a4d4
@jjnicola
Add: get_issue_banner()
31d4128
@jjnicola
Add: get_server_banner()
644a380
@jjnicola
Add: nasl_ssh_get_auth_methods()
e2a20a1
@jjnicola
Add: get_host_key()
ff1190d
@jjnicola
Add: sftp_enabled_check()
6c444b3
@jjnicola
Add: channel member to the SshSession structure
5afac84
@jjnicola
Add: request_shell
93b150f
@jjnicola jjnicola force-pushed the rs-ssh branch 2 times, most recently from 858d3d9 to f3bb39d Compare April 24, 2023 09:42
@jjnicola jjnicola force-pushed the rs-ssh branch 9 times, most recently from a408754 to 210319a Compare April 24, 2023 13:28
@jjnicola
Copy link
Member Author

The Dependency Review CI test is failing because the "Scheme" "MIT/Apache-2.0" is not SPDX compliant and it seems, that the action is only allowing SPDX compliant Licenses.

@jjnicola jjnicola marked this pull request as ready for review April 25, 2023 06:58
@jjnicola jjnicola requested review from a team as code owners April 25, 2023 06:58
nichtsfrei
nichtsfrei requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@nichtsfrei nichtsfrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nitpicking

rust/nasl-interpreter/src/built_in_functions/ssh.rs Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Outdated Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Outdated Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Outdated Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Show resolved Hide resolved
rust/nasl-interpreter/src/built_in_functions/ssh.rs Show resolved Hide resolved
@jjnicola jjnicola enabled auto-merge (squash) April 26, 2023 08:09
@jjnicola jjnicola merged commit 2783f53 into main Apr 27, 2023
@jjnicola jjnicola deleted the rs-ssh branch April 27, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichtsfrei nichtsfrei nichtsfrei approved these changes

@ArnoStiefvater ArnoStiefvater ArnoStiefvater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjnicola @nichtsfrei @ArnoStiefvater