Allow group access to lockfile and fix empty timestamp #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the lockfile to be shared with users in the same group.
This prevents the content being overwritten if the file is locked.
…d-sync-chmod-20.08
jjnicola
requested changes
Jul 30, 2020
tools/greenbone-nvt-sync.in
Outdated
| @@ -511,7 +512,7 @@ do_sync () | |||
| date > $OPENVAS_RUN_DIR/feed-update.lock | |||
| sync_nvts | |||
| echo -n $OPENVAS_RUN_DIR/feed-update.lock | |||
| )9>$OPENVAS_RUN_DIR/feed-update.lock | |||
| )9<$OPENVAS_RUN_DIR/feed-update.lock | |||
There was a problem hiding this comment.
If the file doesn't exist, it will end with an error. It should be open with append flag.
Suggested change
| )9<$OPENVAS_RUN_DIR/feed-update.lock | |
| )9>>$OPENVAS_RUN_DIR/feed-update.lock |
Then, if the flock is successful, the line 512 will overwrite the the content instead of append
There was a problem hiding this comment.
Okay, I've changed it in 5d6fa24 and also in the gvmd PR.
Using read mode does not work if the file does not exist.
jjnicola
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows gvmd and ospd-openvas to be run as different users in the same group and stops the timestamp in the lockfile being cleared when it is already locked.