Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the autohooks Terminal to pontos and replace "print" with the Terminal terms that fit best #127

Merged
merged 9 commits into from
Jun 13, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jun 12, 2021

What:

  • Beautify pontos-release console output by using the awesome autohooks Terminal. ^^
  • Replace print() by fitting terms like warning/ok etc.

Why:

  • Why not?

How:

Checklist:

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #127 (b8a4daf) into master (5fe90b9) will increase coverage by 0.91%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   90.21%   91.13%   +0.91%     
==========================================
  Files          10       11       +1     
  Lines         695      767      +72     
  Branches      106      109       +3     
==========================================
+ Hits          627      699      +72     
  Misses         45       45              
  Partials       23       23              
Impacted Files Coverage Δ
pontos/release/release.py 93.91% <92.00%> (+0.25%) ⬆️
pontos/release/helper.py 98.38% <100.00%> (+0.02%) ⬆️
pontos/terminal/terminal.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe90b9...b8a4daf. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review June 12, 2021 13:12
@y0urself y0urself requested a review from a team June 12, 2021 13:12
@y0urself y0urself enabled auto-merge June 12, 2021 13:22
@y0urself y0urself added the make release To trigger GitHub release action. label Jun 12, 2021
@y0urself y0urself merged commit 61e7432 into master Jun 13, 2021
@y0urself y0urself deleted the y0urself/pontos-terminal branch June 13, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants