Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Improve UpdateHeader to remove old header lines, that are not required anymore #912

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Oct 25, 2023

What

Improve Update Header to remove old header lines, if --cleanup flag set
With a regex these lines are matched and removed

Why

Reduce file sizes, quality optimization, unify headers, ...

References

DEVOPS-833

Checklist

  • Tests

@github-actions
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #912 (adff3c5) into main (c32c192) will decrease coverage by 0.13%.
The diff coverage is 67.64%.

❗ Current head adff3c5 differs from pull request most recent head 1de80d9. Consider uploading reports for the commit 1de80d9 to get more accurate results

@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   90.30%   90.18%   -0.13%     
==========================================
  Files          94       94              
  Lines        6336     6366      +30     
  Branches      892      900       +8     
==========================================
+ Hits         5722     5741      +19     
- Misses        425      432       +7     
- Partials      189      193       +4     
Files Coverage Δ
pontos/updateheader/updateheader.py 80.79% <67.64%> (-3.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@y0urself y0urself marked this pull request as ready for review October 25, 2023 12:04
@y0urself y0urself requested a review from a team as a code owner October 25, 2023 12:04
@y0urself y0urself force-pushed the y0urself/update-update-header branch from 81fe9f6 to 49b1737 Compare October 25, 2023 12:04
@greenbonebot greenbonebot enabled auto-merge (squash) October 25, 2023 12:05
@y0urself y0urself force-pushed the y0urself/update-update-header branch 3 times, most recently from 025e354 to 655b173 Compare October 25, 2023 13:27
@y0urself y0urself added the make release To trigger GitHub release action. label Oct 25, 2023
@y0urself y0urself force-pushed the y0urself/update-update-header branch from 655b173 to adff3c5 Compare October 26, 2023 06:48
@greenbonebot greenbonebot merged commit b3d2bf6 into main Oct 26, 2023
18 checks passed
@greenbonebot greenbonebot deleted the y0urself/update-update-header branch October 26, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants