Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind port mappings to HostIP, if specified #25

Merged
merged 1 commit into from
May 11, 2024

Conversation

stapelberg
Copy link
Collaborator

When using podman run -p 10.25.0.1:8443:8443 before this commit, port 8443 would be reachable on all interfaces, as if one used podman run -p 8443:8443.

This is obviously not great for security — I’m using podman on an internet router with multiple network interfaces and really want to have my container ports reachable only internally, not also on the public internet :)

When using `podman run -p 10.25.0.1:8443:8443` before this commit,
port 8443 would be reachable on all interfaces, as if one used
`podman run -p 8443:8443`.

This is obviously not great for security — I’m using podman on
an internet router with multiple network interfaces and really
want to have my container ports reachable only internally,
not also on the public internet :)
@greenpau
Copy link
Owner

greenpau commented May 9, 2024

@stapelberg , do you want to take on the ownership of this repo? If you do, I will transfer it to you. Nowadays, I am far away from nft and wondering whether the people using it be better off with a maintainer like you.

@stapelberg
Copy link
Collaborator Author

Hey @greenpau! I’m stretched pretty thin myself, but certainly closer to nft and an active user of this project. Feel free to grant me owner permission on the repository and I can help with some best-effort maintenance :)

@greenpau
Copy link
Owner

@stapelberg, this is great! Thank so much! I sent you an invite to join. I am doing it for the first time. Did not see the option to grant you the owner directly. My guess is that after you accept. I set the owner level.

@stapelberg
Copy link
Collaborator Author

Accepted. Let me know how you want to proceed with this PR: Do you want to merge it? Would you prefer if I did?

@greenpau
Copy link
Owner

@stapelberg , please see if you can do it with your current permissions. There is no way for me to add ownership level through this interface.

@stapelberg stapelberg merged commit f47675e into greenpau:main May 11, 2024
2 checks passed
@stapelberg stapelberg deleted the bind-portmap-to-hostip branch May 11, 2024 13:37
@greenpau
Copy link
Owner

Thank you, @stapelberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants