Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "silent" option to cli #351

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

everdimension
Copy link
Contributor

Summary

Solves #347

  • Do not write to stdout when "silent" option is on
  • Update tests

Test plan

Snapshot test has been added.

* Do not write to stdout when "silent" option is on
* Update tests
@vercel
Copy link

vercel bot commented Oct 23, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/neoziro/svgr/ozsanjehjb
🌍 Preview: In Progress

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #351 into master will decrease coverage by 0.35%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   85.06%   84.71%   -0.36%     
==========================================
  Files          30       30              
  Lines         482      484       +2     
  Branches      134      135       +1     
==========================================
  Hits          410      410              
- Misses         60       61       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
packages/cli/src/util.js 66.66% <0%> (-10.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3db0c...8d9c6d5. Read the comment docs.

@gregberge gregberge merged commit 100147f into gregberge:master Dec 18, 2019
@everdimension everdimension deleted the feature/cli-silent-option branch December 19, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants