Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript option #414

Merged
merged 3 commits into from
Mar 22, 2020
Merged

feat: add typescript option #414

merged 3 commits into from
Mar 22, 2020

Conversation

gregberge
Copy link
Owner

Summary

Test plan

@vercel
Copy link

vercel bot commented Mar 22, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/gregberge/svgr/9s3p60sax
✅ Preview: https://svgr-git-typescript-support.gregberge.now.sh

@gregberge
Copy link
Owner Author

@theKashey your review is welcome on this!

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #414 into master will increase coverage by 1.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #414     +/-   ##
=========================================
+ Coverage   84.98%   86.38%   +1.4%     
=========================================
  Files          31       31             
  Lines         526      551     +25     
  Branches      145      151      +6     
=========================================
+ Hits          447      476     +29     
+ Misses         64       60      -4     
  Partials       15       15
Impacted Files Coverage Δ
packages/core/src/config.js 100% <ø> (ø) ⬆️
.../babel-plugin-transform-svg-component/src/index.js 100% <100%> (ø) ⬆️
...s/babel-plugin-transform-svg-component/src/util.js 94.91% <100%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5430f9...30362db. Read the comment docs.

Also add support for JSX in templates (Close #373).
@gregberge gregberge merged commit c380147 into master Mar 22, 2020
@gregberge gregberge deleted the typescript-support branch March 22, 2020 15:05
@theKashey
Copy link

🔥, look like it also brings custom templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants