Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUSTOM-TEMPLATE] write test prove failing scenario #751

Closed

Conversation

cgreene-st
Copy link

@cgreene-st cgreene-st commented Jul 27, 2022

Summary

Cannot add comments to a custom template even though it looks like you should. The feature was added recently (#661) so it should work, but from my testing locally and this draft PR the test fails.

The scenario being, you want to add a comment to top of a custom template, to indicate that it's generated and not to edit. This is especially handy if you're adding the generated icons to source.

Test plan

  • Added a test of the failing scenario but don't have a fix yet.

NOTE: I've edited the snapshot to be what I expect, so the test is currently failing.

@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svgr ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 6:48AM (UTC)

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 1, 2022
@stale stale bot closed this Oct 16, 2022
@gregberge gregberge reopened this Oct 16, 2022
@stale stale bot removed the wontfix label Oct 16, 2022
@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 7, 2023
@gregberge
Copy link
Owner

Closed as staled.

@gregberge gregberge closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants