fixup! Refrain from setting 200 OK on cached responses

gregjones · Nov 16, 2017 · 7b04367 · 7b04367
1 parent 06cbfd4
commit 7b04367
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/httpcache_test.go b/httpcache_test.go
@@ -885,6 +885,9 @@ func TestUpdateFields(t *testing.T) {
 }
 
 func TestCachedErrorsKeepStatus(t *testing.T) {
+	// tests fix for https://github.com/gregjones/httpcache/issues/74
+	// previously, after validating a cached response, its StatusCode
+	// was incorrectly being replaced
 	resetTest()
 	req, err := http.NewRequest("GET", s.server.URL+"/cachederror", nil)
 	if err != nil {
@@ -1393,6 +1396,9 @@ func TestStaleIfErrorResponseLifetime(t *testing.T) {
 }
 
 func TestStaleIfErrorKeepsStatus(t *testing.T) {
+	// tests fix for https://github.com/gregjones/httpcache/issues/74
+	// previously, after a stale response was used after encountering an error,
+	// its StatusCode was being incorrectly replaced
 	resetTest()
 	now := time.Now()
 	tmock := transportMock{