This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Add .travis.yml config and badge. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure gofmted code. - Run go vet. - Run tests with race detector. - Run on 1.6 and tip, but tip is an allowed failure with fast finish on.
|
Of course, if you do merge this, the status will be failing until #38 is resolved. |
gregjones
added a commit
that referenced
this pull request
Mar 12, 2016
Add .travis.yml config and badge.
|
Thanks, very useful. I took the -s of the gofmt check because I didn't know it existed, and have never had my editor set to run it, but will probably revisit that at some point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @gregjones, if you're okay with using Travis for CI, here's a PR that adds a good starting configuration and a badge to the README:
Feel free to close this PR if it's not helpful to you. This is related to https://github.com/gregjones/httpcache/issues/38#issuecomment-195017030.