Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Remove unused resp values. #66

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Remove unused resp values. #66

merged 1 commit into from
Apr 24, 2017

Conversation

dmitshur
Copy link
Collaborator

These values were set, but never used. Assign to blank identifier instead.

Found with staticcheck:

$ staticcheck
httpcache_test.go:1122:2: this value of resp is never used (SA4006)
httpcache_test.go:1209:2: this value of resp is never used (SA4006)

@dmitshur dmitshur requested a review from gregjones April 14, 2017 21:48
@dmitshur
Copy link
Collaborator Author

Friendly ping @gregjones.

Copy link
Owner

@gregjones gregjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

These values were set, but never used. Assign to blank identifier
instead.

Found with staticcheck:

	$ staticcheck
	httpcache_test.go:1122:2: this value of resp is never used (SA4006)
	httpcache_test.go:1209:2: this value of resp is never used (SA4006)
@dmitshur dmitshur merged commit af915bf into master Apr 24, 2017
@dmitshur dmitshur deleted the unused-resp branch April 24, 2017 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants