Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples to the readme, along with cleaning it up a bit. #85

Closed
wants to merge 2 commits into from

Conversation

DanHitt
Copy link
Contributor

@DanHitt DanHitt commented Mar 24, 2016

This saved me a ton of time, thanks a lot! Hope these small changes help someone else new.

@DanHitt
Copy link
Contributor Author

DanHitt commented Mar 24, 2016

Sorry, accidently sent you some other changes which you can discard.

``Entry`` model and tell it to create ten model instances::

(in Python shell)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the >>> notation to indicate that you present an example in the python shell:

>>> from autofixture import AutoFixture
>>> fixture = AutoFixture(Entry)
>>> entries = fixture.create(10)

@gregmuellegger
Copy link
Owner

Thanks a lot for the improvements! I added a few inline comments for things that need adjustment before I can merge it.

@DanHitt
Copy link
Contributor Author

DanHitt commented Mar 24, 2016

Sure, yeah, whatever you think is best. Thanks for letting me help.

On Thu, Mar 24, 2016 at 3:10 PM, Gregor Müllegger notifications@github.com
wrote:

Thanks a lot for the improvements! I added a few inline comments for
things that need adjustment before I can merge it.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#85 (comment)

@DanHitt
Copy link
Contributor Author

DanHitt commented Mar 24, 2016

I'd delete it if you don't have plans for a more detailed readme.

However, when I use it in the future I could add more examples...which are
the main things new users really need.

On Thu, Mar 24, 2016 at 3:20 PM, Dan Hitt d.hitt424@gmail.com wrote:

Sure, yeah, whatever you think is best. Thanks for letting me help.

On Thu, Mar 24, 2016 at 3:10 PM, Gregor Müllegger <
notifications@github.com> wrote:

Thanks a lot for the improvements! I added a few inline comments for
things that need adjustment before I can merge it.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#85 (comment)

gregmuellegger added a commit that referenced this pull request Apr 8, 2016
@gregmuellegger
Copy link
Owner

I merged this but cleaned up the commit before hand so that no sublime specific stuff are in the history, that's why this PR is not marked as merged. Here is your commit in the project: f8fcd0d

Thanks for the work you have put in! This will be part of a new release that goes out today.

@gregmuellegger
Copy link
Owner

Cheers, your patch is in the new release: https://pypi.python.org/pypi/django-autofixture/0.12.1

@DanHitt
Copy link
Contributor Author

DanHitt commented Apr 8, 2016

sweet! thanks!

On Fri, Apr 8, 2016 at 1:54 AM, Gregor Müllegger notifications@github.com
wrote:

Cheers, your patch is in the new release:
https://pypi.python.org/pypi/django-autofixture/0.12.1


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#85 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants