Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] upstream cached pages showing mobile for desktop pages #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alanjds
Copy link
Contributor

@alanjds alanjds commented Jan 13, 2015

We got a client complaining about mobile pages showing up for desktop browsers. Turned up that he uses a Varnish-backed server, and django-mobile serves pages based on User-Agent if MobileDetectionMiddleware is used.

It should set the Vary: User-Agent header.

@gregmuellegger
Copy link
Owner

Hey, that's a very useful addition. Thanks!
However in order to merge this, we would need some basic tests for this. Would you like to step up and write some tests for this? That would really make a difference.
Once this PR has tests, I will merge it and release a new version containing the changes.

@alanjds
Copy link
Contributor Author

alanjds commented Feb 6, 2015

Ouch... I appreciate projects with tests, but I have no experience on coding Unittests, just Doctests. I can do it, but waiting for me will take some time.

@gregmuellegger
Copy link
Owner

gregmuellegger commented Feb 6, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants