WIP: tackle Issue #72 (Django 1.10 Compatibility) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvan
changed the title
|
can you do an iteration on this and fix the tests, so @gregmuellegger can merge it? |
|
ref-ing #72, there is additional information about jinja. |
|
Would love for this to get through. Not sure what's left for it. |
|
I need this merge too... |
diwu1989
reviewed
Mar 30, 2017
| @@ -158,7 +158,7 @@ def test_functional(self): | |||
| result = result.strip() | |||
| self.assertEqual(result, 'Hello .') | |||
| # simulate RequestContext | |||
| result = render_to_string('index.html', context_instance=RequestContext(Mock())) | |||
| result = render_to_string('index.html', context = RequestContext(Mock()).flatten()) | |||
There was a problem hiding this comment.
space before and after the =
context=RequestContext(Mock())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a Django 1.10 support by fetching the loaders in TEMPLATES instead of TEMPLATE_LOADERS.
I now have problems while running the tests:
test_ipad and test_motorola_xoom are failing because for a reason I couldn't identify, the Flavour returned is None.
Any clue about the reason why it happens ?