Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preventing linebreak between anything and isolated stropha #1056

Closed
eroux opened this issue Mar 29, 2016 · 0 comments
Closed

preventing linebreak between anything and isolated stropha #1056

eroux opened this issue Mar 29, 2016 · 0 comments
Assignees
@henryso
Labels
C enhancement
Milestone
4.2

Comments

@eroux
Copy link
Contributor

eroux commented Mar 29, 2016

Gregorio should not cut lines before an isolated stropha. Isolated stropha means here that it's not in a bi/tristropha. And of course this rule applies only to stropha not beginning a syllable. I admit I'm a bit puzzled by the way we should deal with that... should it be merged in the element before it? Why not... What do you think? (that's a request from my contact at Solesmes)
henryso added a commit to henryso/gregorio that referenced this issue Apr 3, 2016
@henryso
Prevented an element cut before an isolated stropha.
977650e 
Fixes gregorio-project#1056.
henryso added a commit to henryso/gregorio-test that referenced this issue Apr 3, 2016
@henryso
Added tests for the change in isolated stropha determination.
c92a0a9 
Tests gregorio-project/gregorio#1056.
This was referenced Apr 3, 2016
Merged
Merged
@henryso henryso added the C label Apr 3, 2016
@henryso henryso added this to the 4.2 milestone Apr 3, 2016
@henryso henryso self-assigned this Apr 3, 2016
@henryso henryso closed this as completed Apr 3, 2016
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Apr 3, 2016
@rpspringuel
Merge commit '53a92da355ea65f880d423c0d45ef1356b2e738f' into feature/…
0233bfd 
…fontdimen

* commit '53a92da355ea65f880d423c0d45ef1356b2e738f':
  Prevented an element cut before an isolated stropha. Fixes gregorio-project#1056.
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Apr 3, 2016
@rpspringuel
Merge commit 'dfeea9f7d90d167ca2d7fac3978bc9a343e5d8a6' into feature/…
03472e7 
…fontdimen

* commit 'dfeea9f7d90d167ca2d7fac3978bc9a343e5d8a6':
  Added tests for the change in isolated stropha determination. Tests gregorio-project/gregorio#1056.

# Conflicts:
#	tests/gabc-dump/glyphs/stropha.pdf - had to be rerun to account for changes on this branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryso henryso

Labels
C enhancement
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@eroux @henryso