Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(efO e) pointing in the wrong direction (?) #1272

Closed
eroux opened this issue Jan 5, 2017 · 5 comments
Closed

(efO e) pointing in the wrong direction (?) #1272

eroux opened this issue Jan 5, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@eroux
Copy link
Contributor

eroux commented Jan 5, 2017

With latest gregorio, if I try

\documentclass[12pt]{article}
\usepackage{fontspec}
\usepackage[autocompile]{gregoriotex}
\begin{document}
\gabcsnippet{(c4) f(efO e)}
\end{document}

I get

bug

while Solesmes would like the oriscus to point to the following note (down)

@henryso henryso self-assigned this Jan 5, 2017
@henryso henryso added this to the 5.0 milestone Jan 5, 2017
@henryso
Copy link
Contributor

henryso commented Jan 5, 2017

As a workaround, you can use e@fo e.

@eroux
Copy link
Contributor Author

eroux commented Jan 5, 2017

Yes, that's what they use

@henryso
Copy link
Contributor

henryso commented Jan 5, 2017

This one is tricky because efO is detected as a particular shape (initially incorrectly called—by me—"virga strata") which is not aware of oriscus direction.

There are two solutions:

  1. Drawing 5 additional glyphs and changing the executable to deal with direction on this shape.
  2. 
    

What do you suggest?

@eroux
Copy link
Contributor Author

eroux commented Jan 5, 2017

That's a good question... I tend to be in favor of option 1 because it will look nicer in pdf viewers and Solesmes seems to use this glyph reasonably often... (and thus chances are that it will appear in a broader way in future scores)

@henryso
Copy link
Contributor

henryso commented Jan 5, 2017

Ok, will do.

henryso added a commit to henryso/gregorio-test that referenced this issue Jan 6, 2017
Updated expectations affected by glyph renames.
Tests gregorio-project/gregorio#1272.
henryso added a commit to henryso/gregorio-test that referenced this issue Jan 6, 2017
@henryso henryso closed this as completed Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants