Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal episema over salicus doesn't render correctly. #511

Closed
henryso opened this issue Jun 20, 2015 · 5 comments
Closed

Horizontal episema over salicus doesn't render correctly. #511

henryso opened this issue Jun 20, 2015 · 5 comments

Comments

@henryso
Copy link
Contributor

henryso commented Jun 20, 2015

This comes from Sr. M. Ruth OSB of Abbazia Mater Ecclesiae via the gregorio-user list.

this gabc:

name: Salicus episemato;
initial-style: 0;
%%
(c4) fhOj___(fhOj___) (::) f_hOj(f_hOj) (::) fhO__j(fhO__j) (::)

in Gregorio 3.0 produces:
image

The develop branch produces something slightly different, but still wrong:
image

@henryso
Copy link
Contributor Author

henryso commented Jun 20, 2015

Since the horizontal episema code is very different in develop, and this will likely require new positioning cases, this would be two separate fixes (for 3.0 and for develop) if we want to fix this in a patch to 3.0. Should I try to fix this in 3.0 or just in develop?

@eroux
Copy link
Contributor

eroux commented Jun 20, 2015

I'd say develop in priority, but if it's not overly complex, it would be good to have it backported in 3.0 too, as Gregorio 4.0 might not be out tomorrow...

@henryso henryso added the fonts label Jun 20, 2015
henryso added a commit to henryso/gregorio that referenced this issue Jun 21, 2015
Fixes gregorio-project#511 for Gregorio develop.

In fixing this, problems with the font were corrected which were necessary to
get the measurements right:
- The pes quassus having ambitus one is made consistent with the salicus
  having second ambitus two.
- The path direction of the virga figure is corrected, allowing it to join
  seamlessly with other glyphs.
henryso added a commit that referenced this issue Jun 27, 2015
@henryso
Copy link
Contributor Author

henryso commented Jun 29, 2015

We're pretty close to a 4.0 beta at this point. Do we still intend to release a 3.0 patch with this fix in it?

@rpspringuel
Copy link
Contributor

I would. Given how the release process for 3.0 went, it will take a couple of months to go from the 4.0-beta to a final release. Seeing as the fix is already done, I see no reason why we can't merge it into master and make a 3.0 release with it.

@henryso
Copy link
Contributor Author

henryso commented Jun 30, 2015

Since you are the release master (and indeed the only person who can build for MacOS at this time), I'll leave it to you to decide when to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants