-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal episema over salicus doesn't render correctly. #511
Comments
Since the horizontal episema code is very different in |
I'd say develop in priority, but if it's not overly complex, it would be good to have it backported in 3.0 too, as Gregorio 4.0 might not be out tomorrow... |
Fixes gregorio-project#511 for Gregorio develop. In fixing this, problems with the font were corrected which were necessary to get the measurements right: - The pes quassus having ambitus one is made consistent with the salicus having second ambitus two. - The path direction of the virga figure is corrected, allowing it to join seamlessly with other glyphs.
We're pretty close to a 4.0 beta at this point. Do we still intend to release a 3.0 patch with this fix in it? |
I would. Given how the release process for 3.0 went, it will take a couple of months to go from the 4.0-beta to a final release. Seeing as the fix is already done, I see no reason why we can't merge it into master and make a 3.0 release with it. |
Since you are the release master (and indeed the only person who can build for MacOS at this time), I'll leave it to you to decide when to do that. |
This comes from Sr. M. Ruth OSB of Abbazia Mater Ecclesiae via the gregorio-user list.
this gabc:
in Gregorio 3.0 produces:
The
develop
branch produces something slightly different, but still wrong:The text was updated successfully, but these errors were encountered: