Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with no newline after a single-syllable word on the last line #675

Closed
henryso opened this issue Nov 23, 2015 · 0 comments
Closed
Assignees
Labels

Comments

@henryso
Copy link
Contributor

henryso commented Nov 23, 2015

If a file has no newline on the last line and the last word is a one-syllable word, the syllable is incorrectly detected as WORD_BEGINNING rather than WORD_ONE_SYLLABLE. If there is a newline after the last word, then the syllable is correctly detected as WORD_ONE_SYLLABLE.

I'm not sure this is a problem in any real-world situation, but it is something peculiar I noticed while debugging some tests.

henryso added a commit to henryso/gregorio that referenced this issue Nov 26, 2015
henryso added a commit to henryso/gregorio-test that referenced this issue Nov 26, 2015
@henryso henryso self-assigned this Nov 26, 2015
henryso added a commit to gregorio-project/gregorio-test that referenced this issue Dec 3, 2015
Updated expectations to match the fix for gregorio-project/gregorio#675.
@henryso henryso closed this as completed Dec 3, 2015
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Dec 9, 2015
* develop:
  Addeds test and expectations for note-in-same-glyph episema height fix. Tests the fix for gregorio-project/gregorio#693.
  Updated expectations to match the fix for gregorio-project/gregorio#675.
  Added gabc-to-gabc tests and expectations.
  Added support for gabc-to-gabc tests.
  Updated expectations to match changes for gregorio-project/gregorio#670.
  Updated test for biginitial style deprecation. Corresponds with changes for gregorio-project/gregorio#632.
  Updated tests and expectations for initial-style deprecation. Corresponds with changes for gregorio-project/gregorio#632.
  Added support for per-gabc-output-test preamble files.
  Updated expectations to match changes for gregorio-project/gregorio#632.
  Added a test for the forced initial hyphen. Corresponds with gregorio-project/gregorio#656. Tests the fix for gregorio-project/gregorio#653.
  Added tests and expectations corresponding to gregorio-project/gregorio#636. This tests the implementation of gregorio-project/gregorio#631.
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Dec 9, 2015
* develop:
  Adding Known Bugs to CHANGELOG
  Making Release
  Called gregorio_strdup instead of strdup.
  Applied fixes suggested by Karl Berry for integration into TeX Live.
  Fixed incorrect detection of note-in-same-glyph for episema height adjustment. Fixes gregorio-project#693.
  Spelling error in CHANGELOG
  Typo in example
  Corrected end-of-word detection when there is no whitespace at end-of-file. Fixes gregorio-project#675.
  Improved the display of enum values in gabc output error messages.
  Modified gabc and dump writers to write only non-deprecated headers. Fixes gregorio-project#670.
  Corrected markdown formatting. Part of the implementation for gregorio-project#632.
  Added \MessageBreak to break up the long message for readability in the log. Fixed missing "else" case in IfStrEq.  Part of the implementation for gregorio-project#632.
  Added change log and upgrade documentation for this change. Part of the implementation for gregorio-project#632.
  Deprecated \gre@style@biginitial. Part of the implementation for gregorio-project#632.
  Added change log with link to gregorio-project#631.
  Deprecated gabc initial-style header. Part of the implementation for gregorio-project#632.
  Documented new and renamed macros. Part of the implementation for gregorio-project#632.
  Refactored first syllable output to allow TeX-controlled initial style. Part of the implementation for gregorio-project#632.
  Corrected escape of hash sign in documentation.
  Implemented salicus flexus glyphs.  Fixes gregorio-project#631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant