-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine space tuning #736
Comments
If the user will need both the current spacing and the negative spacing in the same score, then 1 will not work. The concept of 2 is fine, but using |
Sorry, I've made a few edits so your comment is off by one index, but I'll answer:
|
Using your new numbers, for 3, |
Oh, sorry, markdown ate my space, what I meant was |
As the half space is significant here in terms of gregorian chant, I think it would be good to add |
I agree with doing both 1 and 4. |
I agree with that proposal. |
This would be very useful. The proposal seems good from a user's perspective. |
It occurred to me that at least for the purposes of documentation, it would be useful to establish equivalencies between the "shortcut" notation, and the explicit notation. Something like:
or whatever the actual numbers are. |
Well, they are not really equivalent:
while
which can be different (and are different in By the way, what about the possibility to have floats? like |
I understand that, but what if (arbitrary example with arbitrary numbers) someone decides they want 3/2 of Obviously these equivalencies would only apply to |
I didn't think about In |
See question below. |
I'd rather take floats than fractions in the |
Ok, TeX's primitive |
I agree with this interpretation. |
What is |
Gregorio used to have a clear distinction between glyphs and elements, and |
It seems we have a |
if gabc |
For custom spaces, should stretch ("plus") and shrink ("minus") be scaled by the provided factor, or just the width? |
Part of the implementation for gregorio-project#736.
Tests (part of) the fix for gregorio-project/gregorio#736.
Tests (part of) the fix for gregorio-project/gregorio#736.
In the pull request, I only scaled the width part of the glue and not the stretch or shrink. Let me know if I should do something different. |
Thanks a lot! The space looks perfect! I can't decide about scaling the stretch or shrink... so if there is no objection, we can merge like this. I believe the half space is really useful, but it's kind of difficult to explain, let me try (as it might lead in changes in the code): initially there was a strong differenciation between glyphs and elements, one element being several glyphs separated by some small space. The problem is that it never has been possible to differentiate them in gabc. Let's take the example of the tests in your PR:
but it's not possible to have two podatus in the same element separated by So maybe |
If I'm understanding this, I see two ways of going about it:
Which way depends on whether the |
I think option 1 is the good one, but I'm not 100% sure (I've asked a contact about this). I was thinking about renaming
What do you think? |
It seems funny to release an immediately deprecated feature, so if you want to do this, then I would simply change |
If there's no disagreement, I think it's a good solution yes |
Also, maybe |
The code makes some assumptions about spaces that are at the glyph level, so it might be a little tricky, but I'll try. |
If |
I think it's fine... |
Part of the implementation for gregorio-project#736.
I've made the requested change. Please review. Obviously, a number of test expectations change because of this. |
Hmm sorry, I didn't realize so many spaces would be impacted... I think we can keep |
Part of the implementation for gregorio-project#736.
I've made the requested change. Please review. The only test expectations that change now are due to making "/0" a glyph-level space. |
Thanks a lot! ok for me |
For the new Antiphonale Monasticum project, some differences in the manuscripts are noted with differences in spacing, for instance
f/hoi
will be the transcription for a certain neume, while another will be noted by replacing the space with half a space.The original request was to have the possibility of negative spaces, but I see several:
/0
/
as half a space,//
as a normal space, etc.-/
,-//
and-
for negative spaces, in this casef/-/hoi
would be ok with-/
tuned to be half a space/{1/2}
is half a space,/{-3/2}
is a negative space of width 3/2 of a normal space,/{2}
is a space of twice the normal space, etc.What do you think?
Edit: I've made a few edits since the initial post...
The text was updated successfully, but these errors were encountered: