Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger line piercing flats #882

Closed
eroux opened this issue Feb 6, 2016 · 4 comments
Closed

ledger line piercing flats #882

eroux opened this issue Feb 6, 2016 · 4 comments

Comments

@eroux
Copy link
Contributor

eroux commented Feb 6, 2016

In this image, the ledger line in "piercing" the flat:

bxb

I admit I hoped nobody would ever used this... but the Antiphonale Monasticum project does!

I don't think it's easily fixable, but there should be a way to fix it by hand, for instance by specifiying

  • first a ledger line embracing all the glyphs
  • then all the glyphs, but without the ledger lines

Once there's a way to manually do that (in gabc), then we can think about making the C code output spot this case and output the correct TeX, but I think we can keep that part for later...

@eroux eroux added this to the 4.1 milestone Feb 6, 2016
@henryso
Copy link
Contributor

henryso commented Feb 6, 2016

Would it be possible to save all the positions of the holes and draw them on top on a second pass?

@eroux
Copy link
Contributor Author

eroux commented Feb 6, 2016

That's an idea... It's just not obvious to me how you would do it... In this direction, I'm wondering if it would be possible to do in in the post_linebreakfilter callback in lua, by reducing the left advance of the rule of a ledger line following a cavum glyph... That doesn't sounds too difficult... What do you think?

@eroux
Copy link
Contributor Author

eroux commented Feb 6, 2016

Well, in fact no need to do it in the lua callback, it should even be doable on the pure TeX side, it should be enough to save the information that the last seen glyph is a cavum, and the reduce the size of the ledger line accordingly, it seems even easier!

@henryso
Copy link
Contributor

henryso commented Feb 6, 2016

I was actually thinking about instrumenting all cavum macros to save the position on the page where the cavum hole glyphs should be drawn, and then draw them at the end of each score (in the second pass, of course). However, what you say sounds simpler, although I don't know TeX well enough to fully understand what you are describing.

eroux added a commit to gregorio-project/gregorio-test that referenced this issue Feb 7, 2016
eroux added a commit that referenced this issue Feb 8, 2016
@eroux eroux closed this as completed Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants