Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a \GreLastOfLine-like macro in the syllable before an EUOUAE #988

Closed
henryso opened this issue Mar 1, 2016 · 7 comments
Closed
Assignees
Milestone

Comments

@henryso
Copy link
Contributor

henryso commented Mar 1, 2016

See #984 (comment)

This macro should use the same calculation as to whether the \gre@newlinecommon{1} is inserted in \GreBeginEUOUAE to determine whether it should call \GreLastOfLine

@henryso henryso added this to the 5.0 milestone Mar 1, 2016
@eroux
Copy link
Contributor

eroux commented Mar 2, 2016

I think this could be done easily: the C code could insert a \GreLastSyllableBeforeEUOUAE at the place where it inserts \GreLastOfLine, and this could transform into \GreLastOfLine in appropriate cases...

@henryso
Copy link
Contributor Author

henryso commented Mar 2, 2016

Yes, that's what I was thinking, but I did not have time last night to start working on it.

@eroux
Copy link
Contributor

eroux commented Mar 2, 2016

Sure, I'm just trying to evaluate the work needed for 5.0. I think it should be much lighter than 4.1... but I have the feeling I always think that...

@rpspringuel
Copy link
Contributor

They always start that way, and then something snowballs into a much more complicated or bigger feature than expected.

@eroux
Copy link
Contributor

eroux commented Mar 2, 2016

Indeed... the new bar spacing algorithm was something I wanted to do in 4.0 but didn't have time though, so I knew it would be quite big... I admit i've been surprised by the stem length feature, but I only got positive feedback so far, so chances are that there won't be the need for further work on this... and we get less and less reports... we'll see...

@henryso
Copy link
Contributor Author

henryso commented Mar 2, 2016

This is probably not the best place to discuss this, but since we're on the topic... There is only one deprecation (initial-style) in 4.1, so it would be possible to make the next release 4.2 as long we hold back the removal of that feature. Something to consider which would give people more than a month or so to upgrade their scores to cope with this removal.

@eroux
Copy link
Contributor

eroux commented Mar 2, 2016

That's probably a good idea yes

@eroux eroux modified the milestones: 4.1.1, 5.0 Mar 3, 2016
@henryso henryso self-assigned this Mar 4, 2016
henryso added a commit to henryso/gregorio-test that referenced this issue Mar 4, 2016
eroux added a commit to gregorio-project/gregorio-test that referenced this issue Mar 4, 2016
@eroux eroux closed this as completed Mar 4, 2016
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Mar 6, 2016
…entering

* commit '566525a54ae3d6b60dc193f3fe3d947d11b366c1':
  accept tests for gregorio-project#188
  fix final custos spacings
  fix final custos spacings
  accept changes for additionaltopspacethreshold, etc.
  Updated expectation to match gregorio-project/gregorio#988.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants