Added protrusion handling. #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the implementation for gregorio-project#1029.
Part of the implementation for gregorio-project#1029.
Part of the implementation for gregorio-project#1029.
|
Looks very nice! The test with a protrusion factor of 0.5 is really what I was looking for! |
|
(so if there's o objection, I think we can merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931.
Note: this is built upon changes in the fix-1029 branch, and so merging it will merge that branch as well. It also means the changes are merged in the pull request. You can focus on 87f406c to see the changes specific to this feature.
Tests expectations have been updated and a new test is added for the new feature.
Please review and merge if satisfactory.