Updated spaces from the Italian Antiphonale Project. #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryso
added a commit
to henryso/gregorio-test
that referenced
this pull request
Dec 18, 2016
…oject. Tests gregorio-project/gregorio#1182. Corresponds with gregorio-project/gregorio#1266.
|
Thanks a lot for that! I won't have time for a review today, but I'll review that carefully in the next few days. There will also be adjustments in the inter line spacings, but they don't impact the test in a meaningful way so this can be done separately, it will be straightforward. Thanks again! |
|
I think it's perfect, you did an excellent job at commenting the tests, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1182.
@eroux Please double check that I pulled in all the changes. I didn't set change the eolhyphen or custosalteration settings, and I left the emergency stretch set as
\the\emergencystretch. You'll also see that I changed variousinterwordspacetextvalues from the old ex-dimensioned values (which seemed weird given ex is a relative vertical height) to the cm-dimensioned values for similar spaces from the Italian Antiphonale Project.I added a
CHANGELOG.mdentry, but noUPGRADE.mdbecause I can't see a way that a user can easily "opt out" of these changes.See the corresponding test pull request for notes on the tests.
Please review and merge if satisfactory.