-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added [nocustos] to suppress an end-of-line custos at that point. #1273
Conversation
I think it misses an entry into CHANGELOG, and maybe also in the gabc part of the documentation... The also, currently the test only tests Apart from that, good job, thanks a lot! |
It's unclear to me what you mean by "mixed". Would you please elaborate? |
The gabc part of the documentation does not (unfortunately) currently describe the actual syntax of gabc and rather covers major features that have been added (relatively) recently. I don't think there's a good place in the current documentation to add something about this feature. I think it's OK to leave it out until we do finally document the syntax. |
Well, I think it's necessary to document it somewhere, and enven though the gabc part of the pdf is not really the best place, at least it's somewhere. When someone will compile a gabc documentation, he'll take this as a reference (among other things), and so he'll document About mixed, something like
|
well, without the actual gabc code it's difficult to debug, but you can leave it for another issue if there's something wrong, we can merge this one before... |
I added these "mixed" tests, and you can see the weird pushing past the margin that I mentioned above. Do you have any ideas how I might be able to fix it? |
Hmmm I don't know, maybe the very long texts are too twisted for Gregorio to handle... maybe the most simple solution is to just remove them.... |
I adjusted the test to look nice (and also test the cases you wanted tested). However, if I touch it in certain ways, like removing a I still have to work on the documentation. |
Documentation is in and (I think) the tests are complete. Please review. |
Looks perfect, thanks a lot! |
Fixes #1271.
None of the current tests fail, and I added a test for this feature.
Please review and merge if satisfactory.