Feature/fix 1285 #1335
Merged
Feature/fix 1285 #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug messages weren’t being printed during file loading, so these messages weren’t actually doing anything. Since the log already provides information on which files are being loaded, I’m simply deleting these messages (the other option would be to use `\AtBeginDocument` or the like).
The macro declaring the file version for gregoriotex-main.tex was some 160 lines in, which made it hard to spot. I’ve moved it to closer to the top of the file.
…fix-1285 * commit '6a2c985c40d25bcbe31c4cb0f7c8a2f60885bd84': Documented debug categories. Various documentation fixes. Switched Lua debug messages to use debugmessage. Fixes #1326.
Since `\hskip` is not discretionary friendly, we normally use `\gre@hskip`, which we can redefine when inside a discretionary. However, in examining the this issue (#1285) I found a few places where a normal `\hskip` was still being used. This commit converts all of them to `\gre@hskip`.
Part of the implementation for #1285.
Implemented function to set adjust line height for next line.
…fix-1285 * commit '182b6b92d09f381591eec71ee677b69219fcf93c': Implemented function to set adjust line height for next line. Part of the implementation for #1285.
Fixed infinite recursion.
* fix-1285-v2: Fixed infinite recursion.
Set up the left box using next line heights in \GreDiscretionary.
…fix-1285 * commit 'bd659443c79417477eb094f4440b2dc5518e9bae': Set up the left box using next line heights in \GreDiscretionary. Fixes #1285.
|
I think this needs
|
I’ve also simplified the documentation a bit by making the naming of registers for saved values of distances more consistent. We might want to do something similar for counts in the future.
|
Done. |
|
Assuming everything is tested and working after those renames, I think this looks fine. |
|
I just double checked the tests and we're clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1285
I've also included the various code clean-ups that I discovered while working on this.