Added support for dotted barlines.

[henryso]

Fixes #1360.

Please review and merge if satisfactory.

[rpspringuel]

Did you add just the one style or is the other style somewhere I'm not seeing?

[henryso]

I only added one style that imitates the one in the image. I don't have examples of the other style to try to imitate.

[rpspringuel]

I posted a pdf with a different style. It uses much larger dots (really more like dashes).

[rpspringuel]

I just reupload the image as something that will display directly (you have to download a pdf in order to view it, so it's kind of easy to miss).

I'm running through the tests and have been able to clear at least some (if not all, I'll find out when the tests finish) of the spurious failures by clearing my image cache.

[henryso]

Looking at the sample, I think that's more of a typographic difference rather than a variant/style within the typographic style. I think it's best to just have that be a font thing and don't see a need to put another set of glyphs in the current font. I could put this other style in the gregorio font, if you think that OK.

However this does bring up an issue of the difficulty in redefining bar glyphs. The code currently uses font substitution to select bar glyphs based on number of staff lines. This makes it impossible to change the bar glyphs via glyph substitution. The solution is not as simple as an additional level of indirection because sized bars are defined as variant glyphs. I think the solution will have to be an additional level of indirection plus a renaming of bar glyphs, but I need to think about this a bit more.

[rpspringuel]

Looking at the sample, I think that's more of a typographic difference rather than a variant/style within the typographic style. I think it's best to just have that be a font thing and don't see a need to put another set of glyphs in the current font. I could put this other style in the gregorio font, if you think that OK.

That sounds good.

However this does bring up an issue of the difficulty in redefining bar glyphs. The code currently uses font substitution to select bar glyphs based on number of staff lines. This makes it impossible to change the bar glyphs via glyph substitution. The solution is not as simple as an additional level of indirection because sized bars are defined as variant glyphs. I think the solution will have to be an additional level of indirection plus a renaming of bar glyphs, but I need to think about this a bit more.

Would it be possible to use a sort of offset system? I.e. set things up so that the 2, 3, 4, and 5 line variants of the bar lines always have the same relative location to each other in the code points. We would then add a particular offset which corresponds to the number of lines to a base code point which corresponds to the kind of bar line. Changing to a variant bar line, therefore, would be a matter of changing just the base code point (which should be fairly similar to the way our variant glyph system works for other glyphs), while changing the number of lines would be changing the offset.

[henryso]

I think it's more straightforward to bring in all the sizes of bars into \GreCP variables (e.g., \GreCPVirgulaTwo, \GreCPVirgulaThree, \GreCPVirgulaFour, \GreCPVirgulaFive, etc.) and have the code that switches number of lines set the variables to be used for the given score (e.g., set \GreCPVirgula to \GreCPVirgulaFour for a 4-line staff). Then the user could map these glyphs directly, even with asterisks if the names in the alternate font are the same. This is my current thought, but I have not dived into the code to see how feasible this implementation is.

[henryso]

OK, this should now allow what you need. To use, add:

\grechangeglyph{DivisioMaiorDotted*}{gregorio}{}
\gresetlinesbehinddottedbar{visible}

to your preamble.

[rpspringuel]

The changes look good in the abstract. I'll check them in practice when I am back at my computer. Perhaps one of the tests should be modified to test the variant dotted bar? ✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝ Br. Samuel, OSB (R. Padraic Springuel) PAX ☧ ΧΡΙΣΤΟΣ

…

On Nov 24, 2017, at 7:23 PM, Henry So ***@***.***> wrote: OK, this should now allow what you need. To use, add: \grechangeglyph{DivisioMaiorDotted*}{gregorio}{} \gresetlinesbehinddottedbar{visible} to your preamble. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

[henryso]

Added.

[rpspringuel]

Looks good.