Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTAN related fixes/upgrades #1410

Merged
merged 13 commits into from
Mar 25, 2018
Merged

CTAN related fixes/upgrades #1410

merged 13 commits into from
Mar 25, 2018

Conversation

rpspringuel
Copy link
Contributor

@rpspringuel rpspringuel commented Mar 15, 2018 •
edited
Loading

The original commit is so that make maintainer-clean will remove gregoriotex.ctan.zip if it is present.

@rpspringuel
Remove the CTAN upload package when cleaning up.
f0e148d
@rpspringuel
Fixes to UPGRADE.md
d7c2fc1 
I've added the section for 5.1, as per gregorio-project#1407
I also tried to clarify the top level directions to let people know just how much of the document they need to worry about.
Finally, I noticed a few typos and fixed them.
@rpspringuel rpspringuel changed the title Remove the CTAN upload package when cleaning up. CTAN related fixes/upgrades Mar 15, 2018
@rpspringuel
Copy link
Contributor Author

Rather than open a new PR, I'm adding some other CTAN related changes to this one. I expect that I'll release 5.1.1 shortly after those changes are made (even though, so far at least, they are purely developer or documentation changes).

@rpspringuel
Copy link
Contributor Author

Just addressed #1405 in the simplest possible manner by adding the folder name to the name of the file too. That is fonts/README.md -> fonts/fonts_README.md etc. Let me know if this isn't an acceptable solution.

@rpspringuel
Copy link
Contributor Author

Modifications to VersionManager to address #1403 have now been uploaded.

@henryso
Copy link
Contributor

henryso commented Mar 16, 2018

This looks OK to me. I'd merge it, but I don't know if you're done.

@eschwab eschwab mentioned this pull request Mar 16, 2018
Merged
@rpspringuel
Copy link
Contributor Author

Looking at the issues I've assigned to 5.1.1, there's only #1406 and #1362 to deal with. @eschwab has assigned a separate PR in #1411 for the former, the latter though no one has touched yet. Given the additional work involved in that issue, it probably makes sense to give it its own PR, so I would say this is ready for merge.

@rpspringuel
Copy link
Contributor Author

In reviewing #1411 I found a couple other files which I think that make maintainer-clean ought to remove. Please take a look and confirm.

@henryso
Copy link
Contributor

henryso commented Mar 21, 2018

I think it's fine for maintainer-clean to clean those. Just make sure that distcheck, et al, still work correctly.

@rpspringuel
Copy link
Contributor Author

Thanks for pointing that out. When I ran make distcheck and make ctan I found a couple problems that I've now fixed (and tried to generalize them to fix all targets at the same time). I think I've checked all the primary targets now, but may have missed some of the more obscure ones (being less familiar with make than some). If you have a list of particular targets that you'd like checked, please let me know.

@rpspringuel
TeXLive -> TeX Live
738909a 
I noticed we were inconsistent about this.  I checked with the TeX Live mailing list, and it seems the two word version is preferred.  See http://tug.org/pipermail/tex-live/2018-March/041238.html and following.
@rpspringuel
Remove out of date comment
f7fcf44
@rpspringuel
Copy link
Contributor Author

Okay, I could probably continue to piddle around with this forever so I'm going to force myself to stop here. If there are no objections, I'll merge this on Saturday and then will start working on the 5.1.1 release on Sunday or when #1411 is merged (which ever comes second).

@rpspringuel rpspringuel merged commit c7801f4 into gregorio-project:ctan Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpspringuel @henryso