Considered automatic custos when setting the next custos. #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recomputed the next custos if the clef change discretionary is printed. Fixes gregorio-project#569.
|
A message on the mailing list reminds me that there are some other cases I need to test. I'll work on them tomorrow. |
|
This is now ready for review and merge. I've updated the description to reflect the changes. |
|
Ok ! |
eroux
added a commit
that referenced
this pull request
Aug 21, 2015
Considered automatic custos when setting the next custos.
henryso
added a commit
to gregorio-project/gregorio-test
that referenced
this pull request
Aug 21, 2015
rpspringuel
added a commit
to rpspringuel/gregorio-test
that referenced
this pull request
Aug 21, 2015
…ingiii * commit 'b6a5c6ecee299318974a4f19c7ac6503068a10bd': Updated tests and expectations for gregorio-project/gregorio#571. Corrected the result file location for PDF-based tests when not verifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considered automatic custos when setting the next custos.
Recomputed the next custos if the clef change discretionary is printed.
Fixed the manual custos by reusing the automatic custos code.
Fixes #569.
This is ready for review and merge if acceptable.
Several dump/gtex tests (which use the explicit custos features in various ways) fail, but the new results are appropriate. Because the manual custos is now rendered at the element (rather than glyph) level, there is additional space before it, but this is consistent with automatic custos. This causes the
divisio_finalisoutput test to fail in an acceptable manner. All other tests pass. Once this is merged, I will add a test for these fixes themselves.