Added two-, three-, and five-line staff support. #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apart from my two tiny comments, this looks perfect. This is quite impressive, and really good looking, thanks a lot! |
|
I made the change you suggested to the change log and elevated the warning in |
|
Ok, thanks a lot! |
eroux
added a commit
that referenced
this pull request
Jan 6, 2016
Added two-, three-, and five-line staff support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429.
I'm not sure about the DivisioMinor glyphs, so pay extra attention to them.
Of the current tests, only the gabc-gtex tests fail because of changes to the macros. I added tests for the new feature.
Please review and merge if satisfactory.