forked from dotnet/android
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Xamarin.Android.Build.Tasks] Skip binding lib AndroidManifest.xml's (d…
…otnet#4812) Fixes: dotnet#4804 We were overwriting the `AndroidManifest.xml` file in the `.apk` with ones from Support Libraries. This manifests itself with the following runtime error: Failed to parse APK info: failed to parse AndroidManifest.xml, error: %!s() deploy failed, error: failed to get apk infos, output: W/ResourceType( 5266): Bad XML block: This commit fixes this issue by ignoring files from `.jar` files which already exist in the `.apk`. This stops things from being overwritten. A test has also been added.
- Loading branch information
1 parent
e6603ba
commit ba3fd5b
Showing
4 changed files
with
77 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#### Wrong AndroidManifest.xml packaged to the APK while using binding library | ||
|
||
* [GitHub 4812][0]: We were overwriting the AndroidManifest.xml file | ||
in the apk with ones from Support Libraries. This manifests itself | ||
with the following error | ||
|
||
``` | ||
Failed to parse APK info: failed to parse AndroidManifest.xml, error: %!s() | ||
deploy failed, error: failed to get apk infos, output: W/ResourceType( 5266): Bad XML block: | ||
``` | ||
|
||
|
||
[0]: https://github.com/xamarin/xamarin-android/pull/4812 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters