Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect command-line responses to help command while syncing #2641

Closed
delta1513 opened this issue Feb 23, 2023 · 4 comments · Fixed by #2649
Closed

Incorrect command-line responses to help command while syncing #2641

delta1513 opened this issue Feb 23, 2023 · 4 comments · Fixed by #2649
Assignees
Milestone

Comments

@delta1513
Copy link

Bug Report

Current behavior
When typing help voting while the wallet is syncing, an error message is returned.

Expected behavior
The command help voting should return the help document/message as it would when fully synced.

Steps to reproduce:
Turn off your wallet for a little while or sync from zero and then try running the command.

Gridcoin version
v5.4.1.3-3f2a0955d1a3-dirty

Machine specs

  • OS: Arch Linux
  • CPU: N/A
  • RAM: N/A
  • Disk size: N/A
  • Disk Type (HD/SSD): N/A

Extra information
I found this while manually testing a separate issue and I will be testing this on the main-net wallet soon to confirm and possibly testing some other help commands while syncing in case some other ones are affected.

@delta1513 delta1513 added the bug label Feb 23, 2023
@delta1513
Copy link
Author

Please assign me to this issue, it seems simple enough to take-on.

@jamescowens
Copy link
Member

Any progress on this?

@jamescowens
Copy link
Member

Should be pretty easy. The sync test at voting.cpp:340 is too early (before the help handler). This can be moved to after the help and it should resolve the issue.

@jamescowens jamescowens added this to the LaVerne milestone Mar 4, 2023
@delta1513
Copy link
Author

Was going to get started today or tomorrow. Thanks for the pointers on where to commence!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants