Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add freedesktop.org desktop file and icon set #1438

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Add freedesktop.org desktop file and icon set #1438

merged 5 commits into from
Apr 18, 2019

Conversation

a123b
Copy link
Contributor

@a123b a123b commented Apr 18, 2019

I wrote a desktop file for Gridcoin.

If you want to add a translation or have any suggestions for improvements, leave a comment and I'll try to add it.

I'm also not very familiar with automake, not sure if this is the correct way to do this...

Fixes #280.

@a123b
Add freedesktop.org-compliant icon set
7faa1e9 
If there were already files in share/pixmaps for the correct resolution,
they have just been copied over:
16x16    <- bitcoin.ico (converted to png with icotool)
32x32    <- bitcoin32.png
64x64    <- bitcoin.ico
128x128  <- bitcoin128.png
256x256  <- bitcoin256.png

The scalable svg icon is from src/qt/res/images/gridcoin.svg.
The remaining resolutions (22x22, 24x24, 48x48) have been rendered from
this svg using Inkscape.
@a123b a123b mentioned this pull request Apr 18, 2019
Closed
@denravonska denravonska added this to the Elizabeth milestone Apr 18, 2019
@denravonska
Copy link
Member

Neat :)

GenericName[sv]=Kryptovaluta som belönar beräkningar genom BOINC

@jamescowens
Copy link
Member

This can go in Denise too. Looks ok to me. @TheCharlatan should take a quick look at it.

@jamescowens
Copy link
Member

This appears to mostly work. If I do a compile on my Odroid running Mate, and the do ./configure --with-incompatible-bdb --prefix=/usr and do the full build and then sudo make install, it installs a menu item, but the icon is not shown in the item.

Doing sudo update-icon-caches /usr/share/icons/* updates the icon cache and then the menu item/desktop item is displayed properly.

I am not sure whether it is appropriate for the make install to execute that command. Comments?

@a123b
Copy link
Contributor Author

a123b commented Apr 18, 2019

Added Swedish translation. Also dropped the -qt from the .desktop filename to be consistent with the executable and icon name.

As for the icon cache issue, this is only an issue if you do a local make install. Don't know how common that still is nowadays. If you install it as a package, it's up to the package manager to call these commands anyway (I think update-desktop-database and update-mime-database should also be called). I even think this is somewhat distro-specific, for example on openSUSE and Arch I don't have update-icon-caches, but gtk-update-icon-cache...

@jamescowens
Copy link
Member

Only devs :). Based on that I think good to go.

@jamescowens
Copy link
Member

Merging to dev for testing. @denravonska do we want to put this in Denise (staging) too?

@jamescowens jamescowens merged commit b20f470 into gridcoin-community:development Apr 18, 2019
denravonska added a commit that referenced this pull request May 10, 2019
@denravonska
4.0.3.0-leisure
01c88b0 
Added:
 - Replace NeuralNetwork with portable C++ scraper #1387 (@jamescowens,
   @tomasbrod, @Cycy, @TheCharlatan, @denravonska).
 - Allow compile flags to be used for depends #1423 (@G-UK).
 - Add stake splitting and side staking info to getmininginfo #1424
   (@jamescowens).
 - Add freedesktop.org desktop file and icon set #1438 (@a123b).

Changed:
 - Disable Qt for windows Travis builds #1276 (@TheCharlatan).
 - Replace use of AppCache PROJECT section with strongly-typed structures #1415
   (@cyrossignol).
 - Change dumpwallet to use appropriate data directory #1416 (@jamescowens).
 - Optimize ExtractXML() calls by avoiding unnecessary string copies #1419
   (@cyrossignol).
 - Change signature of IsLockTimeWithinMinutes #1422 (@jamescowens).
 - Restore old poll output for getmininginfo RPC #1437 (@a123b).
 - Prevent segfault when using rpc savescraperfilemanifest #1439 (@jamescowens).
 - Improve miner status messages for ineligible staking balances #1447
   (@cyrossignol).
 - Enhance scraper log archiving #1449 (@jamescowens).

Fixed:
 - Re-enable full GUI 32-bit Windows builds - part of #1387 (@jamescowens).
 - Re-activate Windows Installer #1409 (@TheCharlatan).
 - Fix Depends and Travis build issues for ARM #1417 (@jamescowens).
 - Fix syncupdate icons #1421 (@jamescowens).
 - Fix potential BOINC crash when reading projects #1426 (@cyrossignol).
 - Fix freeze when unlocking wallet #1428 (@denravonska).
 - Fix RPC after high priority alert #1432 (@denravonska).
 - Fix missing poll in GUI when most recent poll expired #1455 (@cyrossignol).

Removed:
 - Remove old, rudimentary side staking implementation #1381 (@denravonska).
 - Remove auto unlock #1402 (@denravonska).
 - Remove superblock forwarding #1430 (@denravonska).
jamescowens added a commit that referenced this pull request Aug 20, 2019
@jamescowens
4.0.5.0-leisure
ddaaf8d 
Added:
 - Add freedesktop.org desktop file and icon set #1438 (@a123b)
 - Add warning in help for blockchain scan for importprivkey #1469 (@jamescowens)
 - Consolidateunspent rpc function #1472 (@jamescowens)
 - Scraper 2.0 improvements #1481, #1488, #1509, and #1514 (@jamescowens, @cyrossignol)
   - explorer mode operation
   - simplified explainmagnitude output
   - improved convergence reporting, including scraper information in the tooltip when fDebug3 is set
   - improved statistics and SB contract core caching based on a bClean flag in the cache global
   - new SB format and packing for bv11
   - new SB contract hashing (native) for bv11
   - changes to accomodate new beacon approach
   - Implement in memory versioning for team file ETags
 - Implement local dynamic team requirement removal and whitelist #1502 (@cyrossignol)

Changed:
 - Quiet logging for getmininginfo and scraper INFO logging level #1460 (@jamescowens)
 - Spelling corrections #1461, #1462 (@caraka)
 - Update crypto module #1453 (@denravonska)
 - Update .travis.yml for Bionic #1475 (@jamescowens)
 - Create CPID classes and clean up CPID code #1477 (@cyrossignol)
 - Refactor researcher context and CPID harvesting #1480 (@cyrossignol)
   - Remove boinckey export RPC method and import handler
 - Notify when wallet locked in advertisebeacon RPC method #1504 (@cyrossignol)
 - Notify when wallet locked in beaconstatus RPC method #1506 (@cyrossignol)
 - Change spacer minimum height hint #1511 (@jamescowens)

Removed:
 - Remove safe mode #1434 (@denravonska)
 - Remove bitcoin.moc in Makefile.qt.include #1444 (@RoboticMind)
 - Clean up legacy Proof-of-Work functions #1497 (@cyrossignol)

Fixed:
 - Constrain walletpassphrase to 10000000 seconds #1459 (@jamescowens)
 - Straighten out localization in the scraper. #1471 (@jamescowens)
 - Quick fix for rainbymagnitude #1473 (@jamescowens)
 - Correct negation error in scraper tooltip for vScrapersNotPublishing #1484 (@jamescowens)
 - Fix staked block rejection when active researcher #1485 (@cyrossignol)
 - Add back informational magnitude to generated blocks #1489 (@cyrossignol)
 - Add back in the in sync check in ScraperGetNeuralContract #1492 (@jamescowens)
 - Scraper correct team file processing. #1501 (@jamescowens)
 - Have importwallet file path default to datadir #1508 (@jamescowens)
 - Scraper add Beacon Map size check to ensure convergence #1515 (@jamescowens)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescowens jamescowens jamescowens approved these changes

@TheCharlatan TheCharlatan Awaiting requested review from TheCharlatan

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Elizabeth
Development

Successfully merging this pull request may close these issues.
3 participants
@a123b @denravonska @jamescowens