Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary if-statement removed #1685

Merged
merged 1 commit into from
May 25, 2020
Merged

Unnecessary if-statement removed #1685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ bool CMessageHeader::IsValid() const
return false;

// Check the command string for errors
if (true)
{
for (const char* p1 = pchCommand; p1 < pchCommand + COMMAND_SIZE; p1++)
for (const char* p1 = pchCommand; p1 < pchCommand + COMMAND_SIZE; p1++)
{
if (*p1 == 0)
{
Expand All @@ -66,7 +64,6 @@ bool CMessageHeader::IsValid() const
else if (*p1 < ' ' || *p1 > 0x7E)
return false;
}
}

// Message size
if (nMessageSize > MAX_SIZE)
Expand Down