util: Fix Windows API for default data directory with wide characters #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrossignol
force-pushed
the
fix-unicode-paths
branch
from
51b2312
to
16b477d
Compare
jamescowens
approved these changes
Sep 8, 2020
div72
reviewed
Sep 8, 2020
Co-authored-by: div72 <60045611+div72@users.noreply.github.com>
jamescowens
approved these changes
Sep 8, 2020
|
I tested it. No further regression. Putting it in hotfix for public testing. |
jamescowens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a missed
*A()to*W()conversion (#1571) for the Windows API call that resolves the AppData directory for the default wallet data directory. It may solve crashes reported with v5.0.0 when the default data directory contains wide characters.I think this is the last place we need this conversion. The remaining
*A()API calls do not need to handle Unicode characters.